This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Fix rustc build #199
Merged
Fix rustc build #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this lint for, again? |
|
To warn when a doc comment is unused by rustdoc. As simple as that. |
Yamakaky
reviewed
Jul 27, 2017
| @@ -423,6 +424,7 @@ macro_rules! impl_extract_backtrace { | |||
| ($error_name: ident | |||
| $error_kind_name: ident | |||
| $([$link_error_path: path, $(#[$meta_links: meta])*])*) => { | |||
| #[allow(unused_doc_comment)] | |||
| fn extract_backtrace(e: &(::std::error::Error + Send + 'static)) | |||
There was a problem hiding this comment.
Hum, do you know why this one is needed? This item doesn't have a doc.
There was a problem hiding this comment.
But it can because of its meta and then we'll have the issue.
|
Also, could you update the changelog? |
|
Sure. |
|
Done. |
|
Thanks! |
|
Can we make a small release (0.0.x) so I can update cargo dependency please? |
|
I'll see that in this evening CEST. |
|
Any news? :) |
|
Right, on it ^^ |
|
Thanks! :) |
|
0.11.0-rc.1 published. My bad, I should have checked: could you fix https://travis-ci.org/brson/error-chain/jobs/258678124#L322-L334? |
|
Ah right, sorry. I was testing with my own rustc version so I didn't saw it. Sending the fix. |
steveklabnik
added a commit
to steveklabnik/rustdoc
that referenced
this pull request
Aug 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in order to make rust-lang/rust#43009 build successfully.