This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
add alternate implementations of error_chain that do not require types section #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natemara Thank you so much! The comments look like they've been mis-formatted though (they're all unindented now). Can you take a look? |
|
This looks like an issue with rustfmt not handling long lines correctly in |
| @@ -331,7 +331,9 @@ macro_rules! quick_error { | |||
| (FIND_DISPLAY_IMPL $name:ident $item:ident: $imode:tt | |||
| { display($self_:tt) -> ($( $exprs:tt )*) $( $tail:tt )*} | |||
| ) => { | |||
| |quick_error!(IDENT $self_): &$name, f: &mut ::std::fmt::Formatter| { write!(f, $( $exprs )*) } | |||
There was a problem hiding this comment.
This is the line that was causing problems. Rustfmt will complain if you have a line longer than 100 characters.
|
Just one last nit. |
|
I'll fix the remaining indent in a followup. Thanks @natemara ! |
|
Glad to help! |
|
@natemara I've published this as error-chain 0.2.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two alternate implementations of the
error_chainmacro. One allows for an emptytypesblock, the other leaves thetypesblock out entirely. This should fix #5. I also ran rustfmt on lib.rs and quick_error.rs.