Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_logger doc improvements #135

Closed
alexcrichton opened this issue May 19, 2017 · 6 comments · Fixed by #192
Closed

set_logger doc improvements #135

alexcrichton opened this issue May 19, 2017 · 6 comments · Fixed by #192

Comments

@alexcrichton
Copy link
Member

  • Add links
  • Add "Errors" section
  • Add example
@alexcrichton
Copy link
Member Author

We should also clarify the error conditions here to mention there's no memory unsafety, but also clearly state what the error conditions are.

@rap2hpoutre
Copy link
Contributor

@alexcrichton I already wrote (helped by rustaceans!) an example of use of set_logger for the cookbook here: https://brson.github.io/rust-cookbook/logging.html#log-messages-with-a-custom-logger

Do you think we have to write a new different one? Or "copy/pasting" this one is OK? Maybe we should make a shorter example, but I don't know what to remove.

@alexcrichton
Copy link
Member Author

@rap2hpoutre nah copy/pasting sounds great! No need to create more work when it's already done :)

@rap2hpoutre
Copy link
Contributor

rap2hpoutre commented Jun 1, 2017

@alexcrichton Ok done for the example part! see: #186

@alexcrichton
Copy link
Member Author

Awesome! In that case closing.

@budziq
Copy link
Contributor

budziq commented Jun 2, 2017

@alexcrichton hi I would reopen as set_logger doc still misses links and errors section

@dtolnay dtolnay reopened this Jun 2, 2017
@brson brson closed this as completed in #192 Jun 3, 2017
EFanZh pushed a commit to EFanZh/log that referenced this issue Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants