Error generation: add tests and fix Naive variant #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a dataset generating polonius errors in all variants.
2 of the smoke test functions pass the analysis, 4 functions don't.
The `invalidates` facts being empty prevented the variant from generating errors.
Merged
|
Maybe I should have added the successful tests to the (I hadn't done that in order to add assertions about the |
nikomatsakis
approved these changes
Dec 7, 2018
| @@ -207,3 +208,76 @@ fn borrowed_local_error() { | |||
| let facts = parse_from_program(program, &mut tables).expect("Parsing failure"); | |||
| test_facts(&facts, Algorithm::OPTIMIZED); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn smoke_test_errors() { | |||
There was a problem hiding this comment.
ugh. good to test, but we gotta make this more concise.
| @@ -79,6 +79,9 @@ pub(super) fn compute<Region: Atom, Loan: Atom, Point: Atom>( | |||
| // load initial facts. | |||
| subset.insert(all_facts.outlives.into()); | |||
| requires.insert(all_facts.borrow_region.into()); | |||
| invalidates.insert(Relation::from( | |||
| all_facts.invalidates.iter().map(|&(p, b)| ((b, p), ())), | |||
| )); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
polonius_smoke_test: it's a dataset containing both positive and negative cases for polonius, making it easy to test error generation both in unit tests and manually.invalidatesinputs to theNaivevariant, to successfully generate errors.r? @nikomatsakis