ir: Whitelist items that don't generate code to improve derive behavior. #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is going to work in the generic case. For example, what if you're using types from another crate like |
|
Can you put an example? You mean blacklisting |
|
Added two more examples to #1454 |
|
☔ The latest upstream changes (presumably #1540) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ping |
|
Yeah, need to get to rebase this, sorry. I try contributions not to linger a lot, but I usually deprioritize my own work. Will try to do this tonight :) |
emilio
force-pushed
the
non-recursive-derive
branch
2 times, most recently
from
366fccd
to
98a89fc
Compare
When not whitelisting recursively. Fixes rust-lang#1454
emilio
force-pushed
the
non-recursive-derive
branch
from
98a89fc
to
76d1959
Compare
|
Test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not whitelisting recursively.
Fixes #1454