Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix one argument block pointer issue, #1378 #1519

Merged
merged 1 commit into from
Feb 11, 2019
Merged

fix one argument block pointer issue, #1378 #1519

merged 1 commit into from
Feb 11, 2019

Conversation

flier
Copy link
Contributor

@flier flier commented Feb 11, 2019

The block pointer with one argument

bool foo(void (^)(size_t bar));

should be generated as *const ::block::Block<(usize,), ()> instead of *const ::block::Block<(usize), ()>

@flier flier mentioned this pull request Feb 11, 2019
Merged
emilio
emilio approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilio emilio merged commit 9fb016e into rust-lang:master Feb 11, 2019
@emilio emilio mentioned this pull request Feb 11, 2019
Closed
@benw
Copy link

benw commented Feb 11, 2019

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flier @benw @emilio @highfive