Switch defaults from generating unstable Rust to generating stable Rust #757
Labels
Comments
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
I'll take a stab at this one. @highfive: assign me |
|
Hey @jonstites! Thanks for your interest in working on this issue. It's now assigned to you! |
rigelk
added a commit
to rigelk/rust-bindgen
that referenced
this issue
Jun 18, 2017
- changing the Builder::no_unstable_rust method to the Builder::unstable_rust method - changing the --no-unstable-rust flag to a --unstable-rust flag in src/options.rs - changing bindgen-option header in the test headers to remove the --no-unstable-rust flag Fixes rust-lang#757
|
@jonstites sorry, didn't see you had taken it :/ |
rigelk
added a commit
to rigelk/rust-bindgen
that referenced
this issue
Jun 19, 2017
- changing the Builder::no_unstable_rust method to the Builder::unstable_rust method - changing the --no-unstable-rust flag to a --unstable-rust flag in src/options.rs - changing bindgen-flags header in the test headers to remove the --no-unstable-rust flag Fixes rust-lang#757
rigelk
added a commit
to rigelk/rust-bindgen
that referenced
this issue
Jun 19, 2017
- changing the Builder::no_unstable_rust method to the Builder::unstable_rust method - changing the --no-unstable-rust flag to a --unstable-rust flag in src/options.rs - changing bindgen-flags header in the test headers to remove the --no-unstable-rust flag Fixes rust-lang#757
bors-servo
pushed a commit
that referenced
this issue
Jun 19, 2017
switch defaults from generating unstable Rust to generating stable Rust As said in the issue: - changing the Builder::no_unstable_rust method to the Builder::unstable_rust method - changing the --no-unstable-rust flag to a --unstable-rust flag in src/options.rs - changing bindgen-flags header in the test headers to remove the --no-unstable-rust flag - removing --no-unstable-rust flag in ./test/test-one.sh Fixes #757 r? @fitzgen
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current default is definitely the wrong choice.
This involves
changing the
Builder::no_unstable_rustmethod to theBuilder::unstable_rustmethodchanging the
--no-unstable-rustflag to a--unstable-rustflag insrc/options.rsI don't think this will require updating test results since we run all the tests with
--no-unstable-rust, however it may require removing that flag from the test harness. I suggetgit greping for "unstable" to see places in the code base that may require updating.The text was updated successfully, but these errors were encountered: