Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite can_derive_copy[_in_array] as either a graph traversal or fix-point analysis #766

Closed
fitzgen opened this issue Jun 19, 2017 · 5 comments
Closed

Rewrite can_derive_copy[_in_array] as either a graph traversal or fix-point analysis #766

fitzgen opened this issue Jun 19, 2017 · 5 comments
Labels
C-assigned E-less-easy help wanted I-cleanup

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 19, 2017

See #536 for details.
@fitzgen fitzgen mentioned this issue Jun 19, 2017
Closed
6 tasks
@fitzgen fitzgen changed the title Rewrite can_derive_copy[_in_array] as either a graph traversal or analysis Rewrite can_derive_copy[_in_array] as either a graph traversal or fix-point analysis Jun 19, 2017
@fitzgen
Copy link
Member Author

fitzgen commented Jul 20, 2017

Note that in #767, we found it easier to compute the set of things that cannot derive Debug rather than the set of things that can.

@photoszzt
Copy link
Contributor

I think this may involve two sets instead of one set. Named would not be the cannot_derive_copy set but it would be in the cannot_derive_copy_in_array set. Can the monotone framework return two sets instead of one?

@fitzgen
Copy link
Member Author

fitzgen commented Jul 25, 2017

Can the monotone framework return two sets instead of one?

Yep!

@photoszzt
Copy link
Contributor

@highfive assign me

@photoszzt
Copy link
Contributor

Looks like highfive doesn't work. I'm working on this.

@photoszzt photoszzt mentioned this issue Jul 29, 2017
Merged
bors-servo pushed a commit that referenced this issue Aug 3, 2017
Auto merge of #866 - photoszzt:can_derive_copy_array, r=fitzgen
e91d448 
Can derive copy analysis

r? @fitzgen  or @emilio. Fix: #766
bors-servo pushed a commit that referenced this issue Aug 3, 2017
Auto merge of #866 - photoszzt:can_derive_copy_array, r=fitzgen
b1cfa78 
Can derive copy analysis

r? @fitzgen  or @emilio. Fix: #766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-less-easy help wanted I-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitzgen @photoszzt