Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BlobTyBuilder a simple function instead of a builder struct #928

Closed
fitzgen opened this issue Aug 23, 2017 · 2 comments
Closed

Make BlobTyBuilder a simple function instead of a builder struct #928

fitzgen opened this issue Aug 23, 2017 · 2 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Aug 23, 2017

BlobTyBuilder is a struct with a new method for construction and a build method to complete the builder. But it doesn't have any methods to configure the builder or anything like that. So every use is like BlobTyBuilder::new(..).build(). This would be better as a simple function blob(..), since we aren't using it as a builder struct at all.

https://github.com/rust-lang-nursery/rust-bindgen/blob/723e93d1267e58cb1aafd04d221a0dff17e212d9/src/codegen/helpers.rs#L63

@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@MaloJaffre
Copy link
Contributor

I'll try to open a PR shortly.
@highfive: assign me

MaloJaffre added a commit to MaloJaffre/rust-bindgen that referenced this issue Aug 24, 2017
Thanks @fitzgen for the detailed instructions.
Fixes rust-lang#928.
bors-servo pushed a commit that referenced this issue Aug 24, 2017
Simplify helpers::blob

Thanks @fitzgen for the detailed instructions.
Fixes #928.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants