Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default target for expectation files as x86_64-unknown-linux #1073

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

liranringel
Copy link
Contributor

@liranringel liranringel commented Oct 11, 2017

Fixes #1067
I didn't check it on macos because I don't have one, but it will be a surprise if it doesn't work.

@liranringel liranringel force-pushed the linux-default-target branch 2 times, most recently from 4bb7c73 to d8f27eb Compare October 11, 2017 01:37
@pepyakin
Copy link
Contributor

pepyakin commented Oct 11, 2017

@liranringel
Looks great and this actually works! Well, almost, two builder tests were failing, so I fixed them.

Anyway, thank you! This PR should make my life easier!

@pepyakin
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link

📌 Commit f74a52c has been approved by pepyakin

@bors-servo
Copy link

⌛ Testing commit f74a52c with merge 8315646...

bors-servo pushed a commit that referenced this pull request Oct 11, 2017
Make the default target for expectation files as x86_64-unknown-linux

Solves #1067
I didn't check it on macos because I don't have one, but it will be a surprise if it doesn't work.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: pepyakin
Pushing 8315646 to master...

@bors-servo bors-servo merged commit f74a52c into rust-lang:master Oct 11, 2017
@liranringel liranringel deleted the linux-default-target branch October 11, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants