Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy 0.0.133 doesn't build on nightly rust. #1767

Closed
o01eg opened this issue May 18, 2017 · 3 comments · Fixed by #1768
Closed

Clippy 0.0.133 doesn't build on nightly rust. #1767

o01eg opened this issue May 18, 2017 · 3 comments · Fixed by #1768

Comments

@o01eg
Copy link
Contributor

o01eg commented May 18, 2017

I got error when trying to install clippy:

error: no method named `populate_implementations_for_trait_if_necessary` found for type `rustc::ty::TyCtxt<'a, 'tcx, 'tcx>` in the current scope
   --> /home/o01eg/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.133/src/utils/mod.rs:328:12
    |
328 |     cx.tcx.populate_implementations_for_trait_if_necessary(trait_id);
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: Could not compile `clippy_lints`.

It looks like it was broken in rust-lang/rust#25323

Rust version:

rustc 1.19.0-dev (0ed1ec9f9 2017-05-18)
binary: rustc
commit-hash: 0ed1ec9f9eb8174273867343d01177b5ac13ff4c
commit-date: 2017-05-18
host: x86_64-unknown-linux-gnu
release: 1.19.0-dev
LLVM version: 3.9
@oli-obk
Copy link
Contributor

oli-obk commented May 19, 2017

I won't get to this today. But it looks like a simple renaming. If someone could whiz up a PR that would speed up the process of getting this fixed

@messense
Copy link
Contributor

messense commented May 19, 2017

It's actually broken in https://github.com/rust-lang/rust/pull/41911/files#diff-c888afeccd78f53e5ea3eb04089e46ddL2333

The populate_implementations_for_trait_if_necessary got removed for some reason.

@oli-obk
Copy link
Contributor

oli-obk commented May 19, 2017

published as 0.0.134

Thanks @messense for creating a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants