Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on extraneous, unnecessary semicolons #266

Closed
frewsxcv opened this issue Aug 31, 2015 · 4 comments
Closed

Warn on extraneous, unnecessary semicolons #266

frewsxcv opened this issue Aug 31, 2015 · 4 comments
Labels
A-lint Area: New lints S-needs-discussion Status: Needs further discussion before merging or work can be started T-AST Type: Requires working with the AST

Comments

@frewsxcv
Copy link
Member

fn main() {
    ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    println!("Hello, world!");
}
@Manishearth Manishearth added good-first-issue These issues are a good way to get started with Clippy T-AST Type: Requires working with the AST A-lint Area: New lints S-needs-discussion Status: Needs further discussion before merging or work can be started and removed good-first-issue These issues are a good way to get started with Clippy labels Aug 31, 2015
@Manishearth
Copy link
Member

I'm not sure how to do this, ast-json on that code gives nothing checkable (the semicolons are parsed out?)

There are still ways of doing this though.

@llogiq
Copy link
Contributor

llogiq commented Sep 1, 2015

We'd need to look at the actual code (via snippet) if available.

@sanmai-NL
Copy link
Contributor

Can we close this and approach this as a rustfmt concern instead?

@oli-obk
Copy link
Contributor

oli-obk commented Feb 19, 2018

Yea I agree, this should be solved by rustfmt

@oli-obk oli-obk closed this as completed Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: New lints S-needs-discussion Status: Needs further discussion before merging or work can be started T-AST Type: Requires working with the AST
Projects
None yet
Development

No branches or pull requests

5 participants