Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clippy.toml an unstable feature #3013

Closed
oli-obk opened this issue Aug 7, 2018 · 6 comments
Closed

Make clippy.toml an unstable feature #3013

oli-obk opened this issue Aug 7, 2018 · 6 comments
Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Milestone

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Aug 7, 2018

We could simply place it behind some sort of CLIPPY_UNSTABLE_CONFIG_TOML=1 flag that users can use but would need to be aware that we'd deprecate the support for it at some point and move to another file at which point the use of the env var would become an error (and the clippy.toml would get ignored)

discussion rust-lang/rfcs#2476 (comment)

@oli-obk oli-obk added this to the 1.0 milestone Aug 7, 2018
@phansch phansch self-assigned this Sep 3, 2018
@phansch phansch added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Sep 13, 2018
@phansch
Copy link
Member

phansch commented Sep 13, 2018

Currently blocked due to pending decision at rust-lang/rfcs#2476 (comment)

@phansch phansch removed their assignment Oct 26, 2018
@phansch
Copy link
Member

phansch commented Sep 7, 2020

Update: It was decided at the time that clippy.toml should be unstable in the RFC: rust-lang/rfcs#2476 (comment)

However, I do fear that it might be too late to make it unstable now (almost 2 years later)?

@flip1995
Copy link
Member

I mean we could make it unstable in an edition (if also tools can use editions for such things). But only if we replace it with something stable, like a lints.toml file (I want to write a RFC for this soon).

Or we just introduce a warning for the clippy.toml file and provide tooling to convert it to the new configuration and support both for a few releases.

@tgross35
Copy link
Contributor

Options for a config file are discussed more in depth on #6625 - since there isn't much discussion here, could this be closed as a duplicate?

@flip1995
Copy link
Member

We'll probably won't turn this into an unstable feature now. We're way past this point.

@tgross35
Copy link
Contributor

We'll probably won't turn this into an unstable feature now. We're way past this point.

I was kind of hoping it wouldn't go away 🙂 thanks for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Development

No branches or pull requests

4 participants