This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Fix out of bounds access in parse_snippet #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
force-pushed
the
fix_out_of_bounds
branch
from
87949a5
to
df1bba0
Compare
oli-obk
reviewed
Mar 25, 2019
src/lib.rs
Outdated
|
|
||
| // If we get a DiagnosticSpanLine where highlight_end > text.len(), we prevent an 'out of | ||
| // bounds' access by using text.len() - 1 instead. | ||
| let last_tail_index = if (last.highlight_end - 1) > last.text.len() { |
There was a problem hiding this comment.
let last_tail_index = last.highlight_end.min(last.text.len()) - 1;should do the same thing.
|
Do we actually want to validate and fix this? We can also do (I don't mind either way) |
|
This particular diagnostic from rustc doesn't provide a suggestion anyway and I'm not sure if there are other diagnostics that provide a suggestion and would cause this crash :/ |
|
I think truncating is fine. We can create a diagnostics json validator later which does a bunch of sanity checks. We can then use that to improve the output generated by rustc. |
oli-obk
approved these changes
Mar 25, 2019
killercup
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164