Add initial wasm memory grow/current intrinsics #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes access to the `grow_memory` and `current_memory` instructions provided by wasm in what will hopefully be a stable interface (the stable part being x86 first in theory).
gnzlbg
reviewed
Mar 9, 2018
| @@ -1,6 +1,8 @@ | |||
| //! Caches run-time feature detection so that it only needs to be computed | |||
| //! once. | |||
|
|
|||
| #![allow(dead_code)] // not used on all platforms | |||
|
|
|||
There was a problem hiding this comment.
I would prefer if we would just disable the detect module in the platforms in which it is not used. I can do this in the MIPS PR since I've cleaned up the detect module there quite a bit.
|
LGTM! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes access to the
grow_memoryandcurrent_memoryinstructionsprovided by wasm in what will hopefully be a stable interface (the stable part
being x86 first in theory).