Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today some of the traits are implemented for vectors, and some of them are implemented for scalars:
This PR fixes these errors for all operators. The implementation is compartmentalized so that we don't need to stabilize all of these at once. For example, we can stabilize (vector, vector) -> vector binary ops first, and decide on (vector, scalar) -> vector and (scalar, vector) -> vector later.
It is important to be comprehensive with the
std::ops
traits because due to trait coherence users cannot implement them themselves on the portable vector types. Having these available on nightly should help with experimentation.