Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cargo check for documentation #10025

Open
GuillaumeGomez opened this issue Nov 1, 2021 · 4 comments
Open

Feature request: cargo check for documentation #10025

GuillaumeGomez opened this issue Nov 1, 2021 · 4 comments
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-check Command-doc S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 1, 2021

Summary

The --check option has been implemented in rust-lang/rust#78984. It'd be nice to be able to use it through cargo.

Unresolved Issues

No response

Future Extensions

When the --check is stabilized on rustdoc, it'd be nice to run it by default on cargo check.

@GuillaumeGomez GuillaumeGomez added the C-tracking-issue Category: A tracking issue for something unstable. label Nov 1, 2021
@Manishearth
Copy link
Member

cc @rust-lang/rustdoc

@gilescope
Copy link
Contributor

nice - this is not running the tests I assume? Would love cargo check --all to include doc --check.

@jyn514
Copy link
Member

jyn514 commented Nov 26, 2021

nice - this is not running the tests I assume? Would love cargo check --all to include doc --check.

No, this doesn't currently check doctests. (I assume that's what you mean - running the tests in a command called check seems very confusing).

There's a lot of uncertainty around here right now - here's the most recent discussion: rust-lang/rust#73314 (comment)
That suggests having check --doc and check --doctests be different, but still both be included in --all-targets. I like that idea, I think it's confusing to combine doctests and rustdoc lints.

@jyn514
Copy link
Member

jyn514 commented Nov 26, 2021

#10026 (comment)

There would be a little inconsistency between cargo test --doc and cargo check --doc if the latter checks the docs but not the doc-examples.

@Nemo157 I agree this is confusing, but I don't know if it's more confusing that combining the two; I think it's better to lean on the side of giving people more options.

@ehuss ehuss changed the title Tracking Issue for doc --check Feature request: cargo check for documentation Apr 25, 2023
@ehuss ehuss added Command-doc Command-check C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. and removed C-tracking-issue Category: A tracking issue for something unstable. labels Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-check Command-doc S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Projects
None yet
Development

No branches or pull requests

5 participants