Suggest cargo uninstall when cargo rm found nothing but an installed binary with the same name

[weihanglo]

Problem

As cargo-rm is going to stabilize, people might make a mistake that using cargo rm to uninstall installed binaries. It would be helpful if Cargo guides them to run cargo uninstall to do a real uninstall.

Proposed Solution

The remove happens here. And this is how the result of cargo install --list get retrieved.

We can make remove_from_table return a CargoResult<bool> to indicate the existence of the given dependency. Then in ops::cargo_remove::remove we can query the installed binary list and make a suggestion like:

the dependency `{name}` could not be found in `{table}`,
but found an installed binary `{name}`.

Run `cargo uninstall {name}` if you want to uninstall the binary.

Notes

If there is already a similar issue, I am sorry and maintainer can close this.

This feature may be too clever. I believe somebody will hit filesystem permission issues and complain cargo remove shouldn't touch things outside the current package.

Personally, I don't want Cargo starts giving false positive suggestions. If we are not confident in our suggestions, maybe don't give any. (or at least use a less assertive tone)

[weihanglo]

Just realized this is a good example that each cargo command reuses ops from each other.

[EpicLiem]

Can you assign this to me?

[weihanglo]

Feel free to use triagebot to do so.

[EpicLiem]

@rustbot claim