Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo fix hard-codes the bug report URL #11877

Closed
jyn514 opened this issue Mar 22, 2023 · 3 comments · Fixed by #11882
Closed

cargo fix hard-codes the bug report URL #11877

jyn514 opened this issue Mar 22, 2023 · 3 comments · Fixed by #11882
Assignees

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 22, 2023

fix applies to more tools than just rustc itself; cargo clippy --fix is supported on stable, and I hope to make rustdoc lints fixable in the future: #13025

It would be nice to make this the correct url for each tool, either by making it configurable somehow or hard-coding a different URL per-tool.

after fixes were automatically applied the compiler reported errors within these files:

  * src/main.rs

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust/issues
quoting the full output of this command we'd be very appreciative!

Originally posted by @jyn514 in rust-lang/rust#109486 (comment)

@ehuss ehuss transferred this issue from rust-lang/rustfix Mar 22, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 22, 2023

Transferred to rust-lang/cargo as this message is generated from cargo.

@hi-rustin
Copy link
Member

@rustbot claim

I will try to improve it.

@weihanglo
Copy link
Member

Note that although #11882 is a bit hacky (check if rustc workspace wrapper is clippy) and still hard-coded, it looks sufficient for today's needs. We could expand it more in the future if more tools come out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants