Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo metadata's resolve output doesn't specify depenency kinds #3984

Closed
sfackler opened this issue Apr 30, 2017 · 4 comments · Fixed by #7132
Closed

cargo metadata's resolve output doesn't specify depenency kinds #3984

sfackler opened this issue Apr 30, 2017 · 4 comments · Fixed by #7132
Labels
A-build-dependencies Area: [build-dependencies] A-crate-dependencies Area: [dependencies] of any kind A-dev-dependencies Area: [dev-dependencies] C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-metadata

Comments

@sfackler
Copy link
Member

cargo-tree needs to know the kind of dependencies (i.e. normal, build, dev) before it can switch over to using cargo metadata rather than linking to cargo as a library.
@alexcrichton
Copy link
Member

This seems reasonable to me! Serialization currently happens here and we'd probably just tweak the dependencies list slightly in Node

@sfackler
Copy link
Member Author

sfackler commented May 1, 2017

Seems like this'd require a metadata version bump, right?

@matklad
Copy link
Member

matklad commented May 2, 2017

Seems like this'd require a metadata version bump, right?

Adding new keys doesn't need a version bump, the clients should ignore extra keys.

@alexcrichton
Copy link
Member

Ah yeah I think it may require some intrusive code changes, but I figured we could just add keys to the maps emitted.

@carols10cents carols10cents added A-build-dependencies Area: [build-dependencies] A-crate-dependencies Area: [dependencies] of any kind A-dev-dependencies Area: [dev-dependencies] Command-metadata C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` labels Oct 2, 2017
@sfackler sfackler mentioned this issue May 2, 2018
Merged
@matklad matklad mentioned this issue May 28, 2018
Closed
@ehuss ehuss mentioned this issue Jul 14, 2019
Merged
@bors bors closed this as completed in d0a41be Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-dependencies Area: [build-dependencies] A-crate-dependencies Area: [dependencies] of any kind A-dev-dependencies Area: [dev-dependencies] C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` Command-metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add kind/platform info to cargo metadata ehuss/cargo
4 participants
@alexcrichton @carols10cents @sfackler @matklad