Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for build script cargo:rustc-cfg are unclear #7338

Closed
Lokathor opened this issue Sep 6, 2019 · 2 comments · Fixed by #7565
Closed

Docs for build script cargo:rustc-cfg are unclear #7338

Lokathor opened this issue Sep 6, 2019 · 2 comments · Fixed by #7565
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-bug Category: bug

Comments

@Lokathor
Copy link

Lokathor commented Sep 6, 2019

In the Build Scripts page the docs for cargo:rustc-cfg give it as rustc-cfg=FEATURE, but apparently the correct form is to use cargo:rustc-cfg=feature=\"feature_name\" , so perhaps we should update that page.
@Lokathor Lokathor added the C-bug Category: bug label Sep 6, 2019
@sfackler
Copy link
Member

sfackler commented Sep 7, 2019

rustc-cfg=FEATURE will enable #[cfg(FEATURE)].

@Lokathor
Copy link
Author

Lokathor commented Sep 7, 2019

ooooooooooooh

Yeah that's not clear in the docs.

@ehuss ehuss added the A-documenting-cargo-itself Area: Cargo's documentation label Sep 21, 2019
@ehuss ehuss mentioned this issue Nov 6, 2019
Merged
@bors bors closed this as completed in #7565 Nov 7, 2019
@bors bors closed this as completed in 22b08c4 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand documentation on build scripts. ehuss/cargo
3 participants
@ehuss @sfackler @Lokathor