Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select required sub-modules of a git dependency #9872

Closed
kvark opened this issue Sep 3, 2021 · 2 comments
Closed

Select required sub-modules of a git dependency #9872

kvark opened this issue Sep 3, 2021 · 2 comments
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@kvark
Copy link

kvark commented Sep 3, 2021

When cargo sees a git dependency, it fetches all the submodules - https://github.com/gfx-rs/wgpu/pull/1903/checks?check_run_id=3508714595#step:5:9

Describe the problem you are trying to solve
This can take minutes of CI time, which is a waste if these submodules aren't really needed.

Describe the solution you'd like

foo  = { git = "https://foo.com/foo", submodules = ["x", "y"] }

Notes
Related to gfx-rs/wgpu#1903

@kvark kvark added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Sep 3, 2021
@ehuss
Copy link
Contributor

ehuss commented Sep 3, 2021

Thanks for the request! I think this is a duplicate of #4247 (and #7987 to a lesser extent), so closing in favor of that.

@ehuss ehuss closed this as completed Sep 3, 2021
@kvark
Copy link
Author

kvark commented Sep 3, 2021

Oh great! I did look for the duplicates and somehow missed these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Development

No branches or pull requests

2 participants