Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor chalk lowering #114

Closed
nikomatsakis opened this issue Apr 30, 2018 · 1 comment
Closed

refactor chalk lowering #114

nikomatsakis opened this issue Apr 30, 2018 · 1 comment

Comments

@nikomatsakis
Copy link
Contributor

Chalk lowering grew rather organically and is kind of a mess. It should be separated out into distinct modules and phases. There was some recent discussion from the WG-traits gitter channel laying out some of the problems and ideas.

@scalexm
Copy link
Member

scalexm commented Apr 30, 2018

Basically, we would have two new modules:

  • a sub module ir/lowering which would deal with translating chalk-parse AST to chalk constructs (constructs found in ir/mod.rs)
  • a new module rules which would deal with outputting program clauses and doing various things around it like default impls and WF requirements; this module could probably be split in multiple files, one for each type of rule

I guess we would keep the coherence module untouched, and we would probably continue to add things about specialization in that module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants