Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel compilation support strategy #492

Open
pnkfelix opened this issue Mar 4, 2022 · 0 comments
Open

Parallel compilation support strategy #492

pnkfelix opened this issue Mar 4, 2022 · 0 comments

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Mar 4, 2022

Meeting proposal info

  • Title: Parallel compilation support strategy
  • Type: technical

Summary

Rust's parallel compilation support is very much experimental. It does have some CI dedicated to it, but recent investigations from @lqd indicate that that CI support may not be exercising it properly (it is only running atop one core). In any case ICEs in the current parallel compiler are very frequent, according to @lqd

Lets talk about what machine resources we want to dedicate to parallel compilation testing, and how we should try to ensure that they are testing what we think they are testing.

Edit (Mark): https://github.com/rust-lang/rust/blob/6d7684101a51f1c375ec84aef5d2fbdeb214bbc2/compiler/rustc_session/src/options.rs#L1460-L1465 suggests that unless explicitly set, -Zthreads (which is the parallel compiler thread count; it does not affect non-parallel builds) defaults to 1 currently. Nothing in CI sets this, so CI runs with just the one thread, just with all the Mutexes and such enabled.

About this issue

This issue corresponds to a meeting proposal for the compiler team
steering meeting. It corresponds to a possible topic of
discussion. You can read more about the steering meeting procedure
here
.

Comment policy

These issues are meant to be used as an "announcements channel"
regarding the proposal, and not as a place to discuss the technical
details. Feel free to subscribe to updates. We'll post comments when
reviewing the proposal in meetings or making a scheduling decision.
In the meantime, if you have questions or ideas, ping the proposers
on Zulip (or elsewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant