Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -Zast-json #503

Closed
1 of 3 tasks
bjorn3 opened this issue Mar 31, 2022 · 3 comments
Closed
1 of 3 tasks

Remove -Zast-json #503

bjorn3 opened this issue Mar 31, 2022 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@bjorn3
Copy link
Member

bjorn3 commented Mar 31, 2022

Proposal

In the past the Serialize and Deserialize traits were generic over both json and a binary format. This causes unnecessary complexity and hurts performance. For this reason in ... the Deserialize trait was changed to no longer be suitable for json deserialization. rust-lang/rust#85993 will remove this for the Serialize trait too and switch usages to serde_json instead. The -Zast-json implementation however uses this support too. Replacing it with serde_json would likely cause rustc to become bigger. For this reason -Zast-json is removed by this PR. Any/all current use cases of -Zast-json can likely migrate to either using rust-analyzer or a custom rustc driver. Switching to serde_json would require changes to said users anyway due to serde_json encoding enums in a way different from rustc_serialize AFAIK.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@bjorn3 bjorn3 added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Mar 31, 2022
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 31, 2022
@bjorn3 bjorn3 mentioned this issue Mar 31, 2022
Merged
@nnethercote
Copy link

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Mar 31, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 7, 2022
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Apr 13, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nnethercote @apiraino @bjorn3 @rustbot