Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_upload_size not used #3649

Closed
FXTi opened this issue May 26, 2021 · 3 comments
Closed

max_upload_size not used #3649

FXTi opened this issue May 26, 2021 · 3 comments
Labels
C-bug 🐞 Category: unintended, undesired behavior

Comments

@FXTi
Copy link

FXTi commented May 26, 2021

Describe the bug
According to #195, max_upload_size can be set in Cargo.toml to specify crate's max size. However, in 94e3e1b, which seems like some kind of daily refactor commit, this field is set to None.

To Reproduce
Set max_upload_size to some value larger than 10MiB and upload a crate bigger than 10MiB.

Expected behavior
Crate upload normally.

Question
Actually, I' m not sure if this is on purpose. If team don't want this filed to be set, this field should just be removed.

@FXTi FXTi added the C-bug 🐞 Category: unintended, undesired behavior label May 26, 2021
@Turbo87
Copy link
Member

Turbo87 commented May 26, 2021

max_upload_size can be set in Cargo.toml to specify crate's max size

I'm not sure where in #195 you've read that, but I don't think that's how it works.

The max_upload_size column in the database is meant for increasing the regular 10MB upload limit on a case-by-case basis. The column value is manually adjusted in the database, which is also why it's usually just set to None for new crates.

@pietroalbini
Copy link
Member

If you need your limit to be increased please email help@crates.io.

@carols10cents
Copy link
Member

max_upload_size is set manually in the database on a per-crate basis after requesting an increase over the default limit. max_upload_size is used during publish and should not be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

4 participants