Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases-by-author page shows multiple copies of the same release #1852

Open
Nemo157 opened this issue Sep 20, 2022 · 4 comments · Fixed by #1879
Open

Releases-by-author page shows multiple copies of the same release #1852

Nemo157 opened this issue Sep 20, 2022 · 4 comments · Fixed by #1879
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR help-wanted

Comments

@Nemo157
Copy link
Member

Nemo157 commented Sep 20, 2022

On my releases page some crates like git-appraise are repeated multiple times. Seems to be correlated with those releases having had multiple builds performed.

@Nemo157 Nemo157 added C-bug Category: This is a bug A-frontend Area: Web frontend labels Sep 20, 2022
@syphar syphar added the E-easy Effort: Should be easy to implement and would make a good first PR label Sep 20, 2022
@syphar
Copy link
Member

syphar commented Sep 20, 2022

Yep, this is definitely related to multiple builds for a single release.

@syphar
Copy link
Member

syphar commented Sep 21, 2022

I did some test and most solutions in the SQL query I tried actually slow down the query too much.

The real solution is probably to store the latest_build_id on the releases row, the same way we store latest_release_id on the crates row.

For now I'll leave it and focus on other issues.

@Nemo157 Nemo157 linked a pull request Oct 13, 2022 that will close this issue
@syphar
Copy link
Member

syphar commented Oct 14, 2022

@Nemo157 I believe this can still happen on all other release-pages since the join to the builds table is in all pages.

Or am I missing something?

@syphar syphar reopened this Oct 14, 2022
@Nemo157
Copy link
Member Author

Nemo157 commented Oct 14, 2022

Ah yes, it can happen on other pages, but probably never will because there's no chance of us requeuing and rebuilding a release within 25 builds (or whatever the limit is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR help-wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants