Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy_rand/bevy_turborand docs failed to build due to web-time #2420

Closed
Bluefinger opened this issue Feb 19, 2024 · 4 comments
Closed

bevy_rand/bevy_turborand docs failed to build due to web-time #2420

Bluefinger opened this issue Feb 19, 2024 · 4 comments

Comments

@Bluefinger
Copy link

Crate name

bevy_rand

Build failure link

https://docs.rs/crate/bevy_rand/0.5.0/builds/1132356

Additional details

My crates bevy_rand & bevy_turborand both failed their builds in the same way, unable to compile the web-time dependency. However, this dependency is part of bevy, specifically bevy_utils, which seemed to have built just fine here: https://docs.rs/bevy_utils/latest/bevy_utils/ so I wonder if there's something going on with the nightly build, though I'm not able to reproduce this build failure locally.

@Nemo157
Copy link
Member

Nemo157 commented Feb 19, 2024

You have

[package.metadata.docs.rs]
rustc-args = ["--cfg", "docsrs"]

which applies to every crate and causes web-time to attempt to compile its web module even on a non-wasm target (which works for building its docs because rustdoc is more lenient about compile errors inside bodies than rustc).

We now set rustdoc-args = ["--cfg=docsrs"] automatically (which only applies when building your docs, not to your dependencies), so you can remove both of these settings from your metadata.

@Bluefinger
Copy link
Author

Does that also need the all-features part removed as well, or just the rustdoc-args being removed is needed?

@Nemo157
Copy link
Member

Nemo157 commented Feb 19, 2024

all-features is good, it's just the --cfg=docsrs that got added #2390

@Bluefinger
Copy link
Author

Confirmed that the build worked now, thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants