Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features page: link dependent features #2530

Closed
llogiq opened this issue Jun 23, 2024 · 1 comment · Fixed by #2532
Closed

Features page: link dependent features #2530

llogiq opened this issue Jun 23, 2024 · 1 comment · Fixed by #2532
Labels
A-frontend Area: Web frontend E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@llogiq
Copy link
Contributor

llogiq commented Jun 23, 2024

Currently, the features page is already quite helpful for finding out about what dependencies' features a feature will activate, but it would be even more useful to make that depended-on features link to their respective entries in that crate's features page on docs.rs.

@syphar
Copy link
Member

syphar commented Jun 23, 2024

thank you for that idea!

my first hunch is that this is definitely possible.

It would involve:

  • parsing the feature definition properly (things like optional dependencies krate?/feature syntax
  • adding HTML anchors to the feature names in the view
  • using the stored dependencies so we know the semver of the dependences
  • generate a link to the correct anchor on that feature page, for the right semver of that dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants