Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch templating to Tera #740

Closed
Kixiron opened this issue May 1, 2020 · 6 comments
Closed

Switch templating to Tera #740

Kixiron opened this issue May 1, 2020 · 6 comments
Assignees
@Kixiron
Labels
A-frontend Area: Web frontend

Comments

@Kixiron
Copy link
Member

Kixiron commented May 1, 2020

The current templates have lots of redundancy, breaking things into smaller units will help with consistency across pages and maintainability
@Kixiron Kixiron self-assigned this May 1, 2020
@Kixiron Kixiron added E-easy Effort: Should be easy to implement and would make a good first PR minor labels May 1, 2020
@jyn514 jyn514 mentioned this issue May 1, 2020
Merged
@Kixiron
Copy link
Member Author

Kixiron commented May 9, 2020

This has now changed slightly, I've been investigating the tera templating engine as a suitable replacement for handlebars

@jyn514
Copy link
Member

jyn514 commented May 27, 2020

Motivation for tera, as discussed on discord:

  • hot reloading so that modifying templates isn't as painful
  • inheritance in templates
  • more processing done in templates instead of code so we can use more derive(Serialize)
  • better docs

@Kixiron
Copy link
Member Author

Kixiron commented May 27, 2020

All of that culminates into what at the end of the day is better, more modifiable and more maintainable code, which is a bonus on every front

@pietroalbini
Copy link
Member

I'd also be in favor of moving to tera.

This was referenced May 27, 2020
Open
Open
Open
Closed
@Kixiron Kixiron linked a pull request May 29, 2020 that will close this issue
[WIP] Migrate to Tera for templating #786
Closed
12 tasks
@jyn514 jyn514 mentioned this issue Jun 8, 2020
Closed
@Kixiron Kixiron changed the title Optimize handebars templates Switch templating to Tera Jun 8, 2020
@jyn514 jyn514 mentioned this issue Jun 8, 2020
Closed
@jyn514 jyn514 added A-frontend Area: Web frontend and removed E-easy Effort: Should be easy to implement and would make a good first PR minor labels Jun 8, 2020
@Kixiron Kixiron mentioned this issue Jul 4, 2020
Merged
@jyn514
Copy link
Member

jyn514 commented Jul 7, 2020

Status: waiting on the bugs mentioned in #885 to be fixed. Then we can go another round at #879.

@jyn514
Copy link
Member

jyn514 commented Jul 13, 2020

Implemented in #887

@jyn514 jyn514 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kixiron Kixiron

Labels
A-frontend Area: Web frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Migrate to Tera for templating Kixiron/docs.rs
3 participants
@pietroalbini @jyn514 @Kixiron