Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reflect module system as-is #62

Closed
Centril opened this issue Jul 24, 2018 · 9 comments
Closed

Update to reflect module system as-is #62

Centril opened this issue Jul 24, 2018 · 9 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Centril
Copy link
Contributor

Centril commented Jul 24, 2018

Once the module system changes as specified in https://internals.rust-lang.org/t/relative-paths-in-rust-2018/7883 is done, update guide.

@Centril Centril added this to the Release Candidate milestone Jul 24, 2018
@steveklabnik
Copy link
Member

My understanding is that they'll be two different options? @aturon can you add any context here?

@Centril
Copy link
Contributor Author

Centril commented Jul 24, 2018

What I mean is: Whenever one of the options is chosen over the other we should update the guide.

@joshtriplett
Copy link
Member

#74

@steveklabnik steveklabnik added bug Something isn't working help wanted Extra attention is needed labels Sep 18, 2018
@steveklabnik
Copy link
Member

Has an option been chosen?

@Centril
Copy link
Contributor Author

Centril commented Sep 18, 2018

@steveklabnik nope; we elected, for the time being, to stabilize the intersection of anchored_use_paths and uniform_paths which makes us forward compatible with the latter. Basically, if you write use foo::bar; and there is a local item foo as well as a crate foo, the compiler will emit an error proposing that the user disambiguate with either use ::foo::bar; or use self::foo::bar; depending on the user's intended meaning.

In the future, we will likely settle on one of the variants and then we can update the guide to reflect that.

@steveklabnik
Copy link
Member

It appears like this didn't merge yet rust-lang/rust#53130 (comment)

which means it's not in the RC :/

@steveklabnik
Copy link
Member

From @eddyb :

you can't have two variants of a system with feature-gates
so "anchored use paths" is the default on Rust 2018, and has been for a while
only uniform paths require a feature gate and will most likely be a thing later on in 2019 or never shrug
I don't even know what we FCP'd
oh we FCP'd the thing that landed like a week ago

@joshtriplett
Copy link
Member

There was a proposal to let #![feature(uniform_paths)] work in the beta for testing, and then turn it off before the release, but that seems to have been dropped on the floor somewhere.

@Centril
Copy link
Contributor Author

Centril commented Sep 18, 2018

@joshtriplett indeed, I think I was a proponent of that somewhere; but idk what came of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants