Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncRead::poll_read_buf and AsyncWrite::poll_write_buf #1818

Closed
taiki-e opened this issue Aug 20, 2019 · 2 comments
Closed

Add AsyncRead::poll_read_buf and AsyncWrite::poll_write_buf #1818

taiki-e opened this issue Aug 20, 2019 · 2 comments

Comments

@taiki-e
Copy link
Member

taiki-e commented Aug 20, 2019

Add the methods mentioned in #1688.

Another change I'm thinking about is to add poll_{read,write}_buf like tokio's same name methods (poll_read_buf, poll_write_buf). This makes tokio::io::Async* and futures::io::Async* almost identical, so that tokio probably can use the futures's io traits. (Stabilizing this is probably blocked by bytes 0.5 release, but since poll_{read,write}_buf have default implementations, it could be made to work well by adding a feature gate. )

Probably blocked by bytes 0.5-alpha.

cc tokio-rs/tokio#1297

@taiki-e
Copy link
Member Author

taiki-e commented Aug 20, 2019

Perhaps this feature should be initially marked as unstable. (Like current async-await and cfg-target-has-atomic features)

@taiki-e
Copy link
Member Author

taiki-e commented Aug 30, 2019

Closing -- see #1826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant