Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open command #1970

Closed
wants to merge 1 commit into from
Closed

Conversation

amab8901
Copy link

@amab8901 amab8901 commented Dec 29, 2022

Addresses #1969.

This is intended to allow the user to browse the documents with the same convenience as mdbook build --open, but without building a book redundantly when it's already built. And without hijacking the terminal like mdbook watch and mdbook serve.

This is a rough first iteration. I have likely missed some details (I'm new to the codebase).

@amab8901 amab8901 changed the title Add open command Add open command Dec 29, 2022
@mgeisler
Copy link
Contributor

And without hijacking the terminal like mdbook watch and mdbook serve.

I asked on #1969, but maybe it's better here: why how just open the generated files directly? You have them right there on your disk, so they're only a

your-browser book/index.html

away 🙂

@amab8901
Copy link
Author

I think it was mostly a minor issue. I don't remember all the details and it was a while ago. Let's close it for now. If someone else encounters this issue, then can file an issue report and PR and whatnot.

@amab8901 amab8901 closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants