Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit target on menu buttons is too small for mobile #749

Closed
jasongrlicky opened this issue Jul 29, 2018 · 2 comments
Closed

Hit target on menu buttons is too small for mobile #749

jasongrlicky opened this issue Jul 29, 2018 · 2 comments

Comments

@jasongrlicky
Copy link

jasongrlicky commented Jul 29, 2018

Hi there! I just had a really hard time hitting the menu items at the top of the page on my iPhone and was curious about why.

Looking for the reason, I noticed that the style for the menu bar uses margins instead of padding to separate the elements, which creates a "dead zone" in between each of the buttons where clicking in that area doesn't do anything. In general, this is not the type of thing that is useful, since if someone is attempting to click/tap anything up there, they are almost definitely attempting to use a button. Because of this, we can assume that they don't want their not-100%-accurate click/tap to do nothing

I believe this could be remedied by swapping out the margins here for padding. If there is a reason these are margins instead of padding, just let me know, but otherwise I can send in a pull request.

A smaller related UX bug is that there is a whitespace node in between each menu item. Even with the padding switch above, this creates a tiny dead zone in between each button. Removing this whitespace node would be one fix, but also setting the font size to 0 on the .left-buttons class seems to fix it without affecting the rendering when there is no CSS applied. Again, just let me know if there are any reasons against this, and if not I can send in a PR!

Thanks so much for the great tool!

@mattico
Copy link
Contributor

mattico commented Jul 30, 2018

I would happily accept a PR for this!

@jasongrlicky
Copy link
Author

Hey @mattico, thanks for fixing this so quickly! That's gonna be great! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants