Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cargo_metadata in cargo-miri #2393

Closed
RalfJung opened this issue Jul 19, 2022 · 0 comments · Fixed by #2450
Closed

Use cargo_metadata in cargo-miri #2393

RalfJung opened this issue Jul 19, 2022 · 0 comments · Fixed by #2450
Labels
A-cargo Area: affects the cargo wrapper (cargo miri) C-cleanup Category: cleaning up our code E-good-first-issue A good way to start contributing, mentoring is available

Comments

@RalfJung
Copy link
Member

Currently we call cargo metadata and parse its output inside cargo-miri:

miri/cargo-miri/bin.rs

Line 516 in e8095d0

cmd.args(["metadata", "--no-deps", "--format-version=1", "-Zunstable-options"]);

It'd probably be cleaner to use the cargo_metadata crate instead.
@RalfJung RalfJung added A-cargo Area: affects the cargo wrapper (cargo miri) E-good-first-issue A good way to start contributing, mentoring is available C-cleanup Category: cleaning up our code labels Jul 19, 2022
@avrong avrong mentioned this issue Jul 29, 2022
Merged
@bors bors closed this as completed in 44dc49f Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cargo Area: affects the cargo wrapper (cargo miri) C-cleanup Category: cleaning up our code E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use cargo_metadata in cargo-miri avrong/miri
1 participant
@RalfJung