Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large repeat expressions don't adhere to the execution limit #82

Closed
oli-obk opened this issue Nov 17, 2016 · 0 comments · Fixed by #86
Closed

large repeat expressions don't adhere to the execution limit #82

oli-obk opened this issue Nov 17, 2016 · 0 comments · Fixed by #86
Labels
C-bug Category: This is a bug.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Nov 17, 2016

and are really slow, since they use write_value for every single value.

I have some code where I write_value the first value and then just copy those bytes N-1 times over the remaining array fields. Better ideas are very welcome.

old speed:

test repeat        ... bench:     509,773 ns/iter (+/- 96,298)
test repeat_manual ... bench: 313,843,922 ns/iter (+/- 5,732,707)

new speed:

test repeat        ... bench:     366,520 ns/iter (+/- 69,298)
test repeat_manual ... bench: 300,833,908 ns/iter (+/- 8,937,121)

not really worth the improvements. I'll just slap on an execution limit thingy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants