Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming pin_mut! to pin! #32

Closed
taiki-e opened this issue May 18, 2020 · 2 comments
Closed

Consider renaming pin_mut! to pin! #32

taiki-e opened this issue May 18, 2020 · 2 comments

Comments

@taiki-e
Copy link
Member

taiki-e commented May 18, 2020

Considering the stack pinning utilities for shared references are unneeded, we probably don't need mut of pin_mut! macro.
@taiki-e
Copy link
Member Author

taiki-e commented Jun 22, 2020

We can avoid a breaking change by adding this as a reexport of pin_mut!. Then, remove pin_mut! in the next major version. (Actually, I would like to deprecate pin_mut in favor of pin, so it would be better if pin_mut is a reexport.)

@taiki-e taiki-e mentioned this issue Jan 22, 2022
Merged
4 tasks
@taiki-e
Copy link
Member Author

taiki-e commented Apr 5, 2024

Closing - pin_mut! is now soft-deprecated in favor of std::pin::pin! that stabilized in Rust 1.68. (#39)

@taiki-e taiki-e closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taiki-e