Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path and module changes (RFC 2126) #291

Open
3 of 6 tasks
matthewjasper opened this issue Apr 3, 2018 · 2 comments
Open
3 of 6 tasks

Path and module changes (RFC 2126) #291

matthewjasper opened this issue Apr 3, 2018 · 2 comments
Labels
RFC Stabilization Docs Documentation required for stabilizing a feature
Projects
Milestone

Comments

@matthewjasper
Copy link
Contributor

matthewjasper commented Apr 3, 2018

See rust-lang/rust#44660.

  • Paths starting with crate
  • Not needing extern crate
  • crate visibility modifier - not stabilizing in initial release
  • Not using mod.rs
  • Any edition lints
  • Update existing examples
@matthewjasper matthewjasper added S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository RFC Stabilization Docs Documentation required for stabilizing a feature labels Apr 3, 2018
@matthewjasper matthewjasper added this to the Rust 2018 milestone Apr 3, 2018
@matthewjasper matthewjasper added this to Awaiting Docs For Stabilization in RFC Status Apr 3, 2018
@ehuss
Copy link
Contributor

ehuss commented Oct 14, 2018

I have a branch for the extern crate changes, but it is blocked waiting on #415 (I either need to link to or write something that explains the extern prelude). crate visibility is not stable (rust-lang/rust#53120) so I don't think that's relevant here. I opened PR #450 for mod.rs changes.

I'm not sure what is meant by "edition lints". My extern crate changes note that it is unidiomatic in 2018, but I'm not sure what other lints are relevant. Also, I was under the impression lints aren't generally documented here and deferred to the rustc user guide. Are there specific rust_2018_idioms you want to call out?

@ehuss
Copy link
Contributor

ehuss commented Oct 14, 2018

Regarding updating the examples, AFAIK the mdbook playpen links don't support changing the edition, so those links will always break. I can't find this being tracked or mentioned anywhere. I imagine they aren't used very often, but I think it should be tracked somewhere (should I file an mdbook issue?).

@ehuss ehuss removed the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Stabilization Docs Documentation required for stabilizing a feature
Projects
RFC Status
Awaiting Docs For Stabilization
Development

No branches or pull requests

2 participants