Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion list does not contain locals or method parameters. #10652

Closed
twitchax opened this issue Oct 27, 2021 · 4 comments
Closed

Completion list does not contain locals or method parameters. #10652

twitchax opened this issue Oct 27, 2021 · 4 comments

Comments

@twitchax
Copy link

I don't know the exact date this started, but locals and method parameters are not suggested in the completion list on at least a week's worth of nightlies in certain scenarios (stable also seems to have the issue). I will try to find a minimally reproducible example, but I think it has something to do with Rocket, or methods with attributes.

Please see below: the method parameter key is not suggested in the completion list.

image

In addition, if I were to type key., then the list doesn't know the type of the local.

image

Other methods (without attributes seems to be the only difference) work fine.

image

@Veykril
Copy link
Member

Veykril commented Oct 27, 2021

We enabled attribute expansion by default some weeks ago, this fallout is expected for attribute macros that don't handle errors gracefully. See #10498 for more info. Basically rocket has to fix their attributes not re-emitting the function when it errors for r-a to continue to work when typing inside the function.

@twitchax
Copy link
Author

@Veykril, my bad: I did some searching in Rocket, but missed that one. Appreciate the timely response!

@Veykril
Copy link
Member

Veykril commented Oct 27, 2021

No problem, no one reported it for rocket yet I think, at least not here.

@twitchax
Copy link
Author

Awesome: I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants