Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inlay hint location links #11701

Closed
Veykril opened this issue Mar 14, 2022 · 4 comments · Fixed by #13699
Closed

Implement inlay hint location links #11701

Veykril opened this issue Mar 14, 2022 · 4 comments · Fixed by #13699
Labels
A-inlay-hints inlay/inline hints C-feature Category: feature request fun A technically challenging issue with high impact S-actionable Someone could pick this issue up and work on it right now

Comments

@Veykril
Copy link
Member

Veykril commented Mar 14, 2022

The inlay hint api allows to split the hints into parts backed by links, we should make use of this.

https://github.com/rust-analyzer/rust-analyzer/blob/5e8515870674983cce5b945946045bc1e9b80200/crates/rust-analyzer/src/lsp_ext.rs#L273-L283

The main difficulty here is that we currently use HirDisplay to render the display representation of types which doesn't allow introspection into each part. We probably need a proper type visitor api here.

@Veykril Veykril added fun A technically challenging issue with high impact S-actionable Someone could pick this issue up and work on it right now C-feature Category: feature request A-inlay-hints inlay/inline hints labels Mar 14, 2022
@IWANABETHATGUY
Copy link

Hi, since this pr has been landed for a while, what is the progress of go to type definition via a inlayHint

@bigdogs
Copy link

bigdogs commented Apr 26, 2022

Hi, Any new progress for this issue?
BTW. Is this related to the issue that inlay hint tooltip window is not show up ?

@IWANABETHATGUY
Copy link

@Veykril , I would like to have a try, would you mind give me some hints?

@Veykril
Copy link
Member Author

Veykril commented Oct 4, 2022

I'm not sure. as was said in the initial description, we probably need to come up with a proper type visitor API here so we can construct the inlay hint parts correctly. I am not sure how feasible that is yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-inlay-hints inlay/inline hints C-feature Category: feature request fun A technically challenging issue with high impact S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants