Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin #[derive] completions don't take existing derives into account #12019

Closed
jonas-schievink opened this issue Apr 17, 2022 · 1 comment · Fixed by #12024
Closed

Builtin #[derive] completions don't take existing derives into account #12019

jonas-schievink opened this issue Apr 17, 2022 · 1 comment · Fixed by #12024
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now

Comments

@jonas-schievink
Copy link
Contributor 

#[derive(PartialEq, Eq, Or$0)]
struct S;

This completes PartialEq, PartialOrd and PartialEq, Eq, PartialOrd, Ord, both of which are wrong because PartialEq is already derived.
@jonas-schievink jonas-schievink added A-completion autocompletion S-actionable Someone could pick this issue up and work on it right now C-bug Category: bug labels Apr 17, 2022
@xffxff
Copy link
Contributor

xffxff commented Apr 18, 2022

I'll try to fix it.

@xffxff xffxff mentioned this issue Apr 18, 2022
Merged
@bors bors closed this as completed in ebf4658 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't suggest existing #[derive]s in completion xffxff/rust-analyzer
2 participants
@jonas-schievink @xffxff