Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running the proc-macro-srv tests #12999

Closed
lnicola opened this issue Aug 11, 2022 · 1 comment
Closed

Stop running the proc-macro-srv tests #12999

lnicola opened this issue Aug 11, 2022 · 1 comment
Labels
A-proc-macro proc macro

Comments

@lnicola
Copy link
Member

lnicola commented Aug 11, 2022

The crate now has two kinds of tests. The ABI-specific ones are fine, and we'll drop them in due time, but the others only work in the rust-lang/rust tree. We need to find a way to stop running them in this repo.

We could use a Cargo feature (which might require building the tests twice on the downstream CI) or look for an environment variable. Both approaches seem a bit confusing IMHO.
@lnicola lnicola added the A-proc-macro proc macro label Aug 11, 2022
@jonas-schievink jonas-schievink mentioned this issue Aug 29, 2022
Closed
@lnicola
Copy link
Member Author

lnicola commented Oct 10, 2022

Done (kind of) in #13286.

@lnicola lnicola closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-proc-macro proc macro
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lnicola