feature: Links in the error hint should be clickable

[budde25]

rust-analyzer version: (eg. output of "rust-analyzer: Show RA Version" command, accessible in VSCode via Ctrl/⌘+Shift+P)
rust-analyzer version: 0.3.1194-standalone (67920f7 2022-09-04)

rustc version: (eg. output of rustc -V)
rustc 1.63.0 (4b91a6ea7 2022-08-08)

It would be nice if the link to the Github issue was clickable (similar to how clicking the error brings your to the link for that error "rustc(E0658)")

[Veykril]

This is part of VSCode's diagnostics which we don't have any control over I believe. I don't think the diagnostics accept markdown either so we can't really make it a link.

[budde25]

I think this should be possible as in the example above the E0658 is itself a link to the https://doc.rust-lang.org/error-index.html#E0658 so it already does this right? Since the former is straight rustc output it maybe would have to be parsed and converted it whatever vscode seems to like.

I looked into the code and I think this is the code that finds adds those error links?

rust-analyzer/crates/rust-analyzer/src/diagnostics/to_proto.rs

Lines 487 to 499 in 6dfd8ae

	fn rustc_code_description(code: Option<&str>) -> Option<lsp_types::CodeDescription> {
	code.filter(|code| {
	let mut chars = code.chars();
	chars.next().map_or(false, |c| c == 'E')
	&& chars.by_ref().take(4).all(|c| c.is_ascii_digit())
	&& chars.next().is_none()
	})
	.and_then(|code| {
	lsp_types::Url::parse(&format!("https://doc.rust-lang.org/error-index.html#{}", code))
	.ok()
	.map(|href| lsp_types::CodeDescription { href })
	})
	}

[Veykril]

that part is the error code part of diagnostics which supports links, its not the same as the rest of the diagnostics message

[budde25]

Ahh OK thanks for the clarification.