Returns inlay hints outside requested region

[joaotavora]

rust-analyzer version: rust-analyzer 1 (a6603fc21 2023-02-16)

rustc version: rustc 1.67.1 (d5a82bbd2 2023-02-07) (Arch Linux rust 1:1.67.1-1)

relevant settings: No settings that I am aware of. I'm using a bare-bones LSP client that just invoked rust-analyzer without any arguments, initializationOptions, or workspace configuration.

In the communication log between my client and the server, I find this excerpt:

   (:jsonrpc "2.0" :id 216 :method "textDocument/inlayHint" :params
             (:textDocument
              (:uri "file:///home/capitaomorte/Source/Rust/bevy/crates/bevy_animation/src/lib.rs")
              :range
              (:start
               (:line 187 :character 0)
               :end
               (:line 238 :character 31))))
   [server-reply] (id:216) Mon Feb 27 14:11:25 2023:
   (:jsonrpc "2.0" :id 216 :result
             [(:position
               (:line 294 :character 1)
               :label
               [(:value "fn animation_player" :location
                        (:uri "file:///home/capitaomorte/Source/Rust/bevy/crates/bevy_animation/src/lib.rs" :range
                              (:start
                               (:line 185 :character 7)
                               :end
                               (:line 185 :character 23))))]

As you can see, this is requesting inlay hints for a specific region of the document and getting back hints for things outside this region. Easy enough to filter on my side, but I thought I'd report this here.

This was originally reported in Emacs's bug tracker: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61812

[Veykril]

The range restricts the calculation of inlay hints to a subset of the AST, which maybe larger than the passed in range here

rust-analyzer/crates/ide/src/inlay_hints.rs

Lines 374 to 388 in b38fcde

	if let Some(scope) = sema.scope(file) {
	let famous_defs = FamousDefs(&sema, scope.krate());
	let hints = |node| hints(&mut acc, &famous_defs, config, file_id, node);
	match range_limit {
	Some(range) => match file.covering_element(range) {
	NodeOrToken::Token(_) => return acc,
	NodeOrToken::Node(n) => n
	.descendants()
	.filter(|descendant| range.intersect(descendant.text_range()).is_some())
	.for_each(hints),
	},
	None => file.descendants().for_each(hints),
	};
	}

We should filter out inlay hints that lie outside the range from the results.