Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assists are broken #15176

Closed
Veykril opened this issue Jun 30, 2023 · 5 comments · Fixed by #15180
Closed

Assists are broken #15176

Veykril opened this issue Jun 30, 2023 · 5 comments · Fixed by #15180
Labels
A-assists Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Jun 30, 2023

Since today I am unable to use any of our assists, none of them trigger (except for diagnostic quickfixes)
@Veykril Veykril added A-assists Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug labels Jun 30, 2023
@Veykril
Copy link
Member Author

Veykril commented Jun 30, 2023

Looks like we are always panicking in rust_analyzer::handlers::request::handle_code_action

@Veykril
Copy link
Member Author

Veykril commented Jun 30, 2023

Found the cause https://github.com/rust-lang/rust-analyzer/pull/15101/files#r1247491229

@lnicola
Copy link
Member

lnicola commented Jun 30, 2023

These also look iffy, I think?

@Veykril
Copy link
Member Author

Veykril commented Jun 30, 2023

I might've been tired when doing that review ... @alibektas I fixed the main unwrap problem in #15177
Could you clean up the remaining unwraps from your recent PR?

@alibektas
Copy link
Member

Sorry. On it now.

@alibektas alibektas mentioned this issue Jun 30, 2023
Merged
@bors bors closed this as completed in 7a3991a Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-assists Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Purge of unwraps alibektas/rust-analyzer
3 participants
@lnicola @Veykril @alibektas