"Convert identifier to uppercase" code assist doesn't replace references to the variable

[MariaSolOs]

rust-analyzer version: 0.3.1591-standalone (d824511 2023-07-16)

rustc version: rustc 1.72.0-nightly (37998ab50 2023-06-11)

Given the following code:

    const should_foo: bool = true;
    if should_foo {
        println!("foo");
    } else {
        println!("bar");
    }

rust-analyzer will display the "Convert the identifier to upper case" code assist. However, when applying the refactoring only the declaration is updated, not the references.

And so the outcome is:

    const SHOULD_FOO: bool = true;
    if should_foo { // error
        println!("foo");
    } else {
        println!("bar");
    }

[lnicola]

Are you sure about this? Our diagnostic doesn't trigger for inner items, but otherwise the fix works just fine:

Then there's also the warning from rustc which doesn't work properly, CC #7742:

[lowr]

The diagnostic mentioned in OP does come from rustc, which doesn't account for name references, but we should be also reporting the diagnostics for them anyway. #15320 should fix that.

[MariaSolOs]

And as always, I’m impressed by the bug fixing speed of y’all. Thanks a lot!

[MariaSolOs]

@lowr @lnicola Hello again! Quick question: With the latest version of RA I'm now seeing the 2 code actions below:

The first one does correctly update references, while the 2nd one (which is the one I originally mentioned in this issue) still only updates the declaration. I'm not asking for further changes, I just want to better understand the difference between them.

[MariaSolOs]

In particular, from the description of #15320 it sounds like RA just started providing those refactorings, and so who's providing the 2nd one? Because from the UI above it looks like RA is the only code action provider...

[lnicola]

It's from rustc (cargo check), see my comment above.

[MariaSolOs]

It's from rustc (cargo check), see my comment above.

Oh I'm so sorry, I missed that very important last sentence. My bad!