Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: assist to convert between x.into() and T::from(x) #15539

Closed
Kmeakin opened this issue Aug 31, 2023 · 4 comments · Fixed by #15573
Closed

Feature request: assist to convert between x.into() and T::from(x) #15539

Kmeakin opened this issue Aug 31, 2023 · 4 comments · Fixed by #15573
Assignees
@alibektas
Labels
A-assists C-feature Category: feature request

Comments

@Kmeakin
Copy link

Kmeakin commented Aug 31, 2023 •
edited by rustbot

x.into() is easier to write, but T::from(x) is less ambiguous/easier to read. Would be nice to have an assist for doing this automatically
@Kmeakin Kmeakin added the C-feature Category: feature request label Aug 31, 2023
@Veykril

This comment was marked as outdated.

Sign in to view
@flodiebold
Copy link
Member

Also it's not very discoverable to have to realize that inline function will do this 😅

@Veykril
Copy link
Member

Veykril commented Sep 1, 2023

That is a convincing point 😅

@alibektas
Copy link
Member

@rustbot claim

@alibektas alibektas mentioned this issue Sep 7, 2023
Merged
@bors bors closed this as completed in 47e0d07 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alibektas alibektas

Labels
A-assists C-feature Category: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add into_to_qualified_from assist alibektas/rust-analyzer
4 participants
@flodiebold @Veykril @Kmeakin @alibektas