Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-publishing runs out of disk space #15732

Closed
lnicola opened this issue Oct 9, 2023 · 11 comments
Closed

auto-publishing runs out of disk space #15732

lnicola opened this issue Oct 9, 2023 · 11 comments
Assignees
Labels
A-infra CI and workflow issues C-bug Category: bug

Comments

@lnicola
Copy link
Member

lnicola commented Oct 9, 2023

https://github.com/rust-lang/rust-analyzer/actions/runs/6452854701/attempts/1

I think cargo workspaces publish rebuilds common dependencies for each published crate.

@lnicola lnicola added C-bug Category: bug A-infra CI and workflow issues labels Oct 9, 2023
@Veykril
Copy link
Member

Veykril commented Oct 9, 2023

Could be due to difference in default features (of dependencies) being enabled for the crates maybe?

@Veykril
Copy link
Member

Veykril commented Oct 9, 2023

Though why is this happening now? 🤔

@lnicola
Copy link
Member Author

lnicola commented Oct 9, 2023

It's been happening for a couple of weeks now, I think since we added rustc-dependencies.

@lnicola
Copy link
Member Author

lnicola commented Oct 9, 2023

Actually, no, it might be since earlier. I'm not sure.

Could be due to difference in default features (of dependencies) being enabled for the crates maybe?

That would only rebuild some of the crates. Look for "Compiling libc" in this log to see what I mean. As if it's building them independently, outside the workspace.

@pksunkara
Copy link
Contributor

I haven't checked this deeply, but wouldn't cargo publish command always compile freshly? or am I misunderstanding how it works?

@lnicola
Copy link
Member Author

lnicola commented Oct 13, 2023

To be honest, I have no idea.

@pksunkara
Copy link
Contributor

Looks like yes, it does. rust-lang/cargo#4109

@lnicola
Copy link
Member Author

lnicola commented Oct 13, 2023

Ah, good find. Then I guess we can close #137?

@lnicola lnicola self-assigned this Oct 13, 2023
@pksunkara
Copy link
Contributor

Error: The operation was canceled.

I see the above error message in the run you started. Any reason why it was assumed to be related to disk space?

I see that timeout-minutes is not specified for the workflow, so it can't be that.

@lnicola
Copy link
Member Author

lnicola commented Oct 13, 2023

Oh yeah, I just cancelled it so we don't publish anything today. But you can see in the logs that a lot of crates have been built multiple times.

@lnicola
Copy link
Member Author

lnicola commented Oct 19, 2023

@lnicola lnicola closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra CI and workflow issues C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants