Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The location for implicitDrops is kind of hard to read. #16012

Closed
wyatt-herkamp opened this issue Dec 4, 2023 · 1 comment · Fixed by #16028
Closed

The location for implicitDrops is kind of hard to read. #16012

wyatt-herkamp opened this issue Dec 4, 2023 · 1 comment · Fixed by #16028
Assignees
Labels
A-inlay-hints inlay/inline hints C-bug Category: bug E-easy

Comments

@wyatt-herkamp
Copy link
Contributor

wyatt-herkamp commented Dec 4, 2023

rust-analyzer version: rust-analyzer version: 0.4.1755-standalone (e402c49 2023-12-01)

rustc version: (eg. output of rustc -V) rustc 1.75.0-beta.5 (1a06ac5b5 2023-12-01)

relevant settings: (eg. client settings, or environment variables like CARGO, RUSTC, RUSTUP_HOME or CARGO_HOME)

  "rust-analyzer.procMacro.ignored": {
    "tokio-macros": [
      "main"
    ],
    "async-trait": [
      "async_trait"
    ],
    "tracing-attributes": [
      "instrument"
    ],
  },
  "rust-analyzer.inlayHints.lifetimeElisionHints.enable": "skip_trivial",
  "rust-analyzer.inlayHints.lifetimeElisionHints.useParameterNames": true,
  "rust-analyzer.inlayHints.closingBraceHints.enable": false,
  "rust-analyzer.inlayHints.expressionAdjustmentHints.enable": "reborrow",
  "rust-analyzer.inlayHints.implicitDrops.enable": true, // This is the most relevant setting
  "rust-analyzer.inlayHints.expressionAdjustmentHints.hideOutsideUnsafe": true,
  "rust-analyzer.inlayHints.reborrowHints.enable": "mutable",
  "rust-analyzer.rustfmt.extraArgs": [
    "+nightly"
  ],

image

I think the location of drop(_) should be after the }/ curly bracket.
It makes it kind of hard to read with it shifting the curly to the right.

@wyatt-herkamp wyatt-herkamp added the C-bug Category: bug label Dec 4, 2023
@HKalbasi HKalbasi added the E-easy label Dec 4, 2023
@Young-Flash
Copy link
Member

interesting, I'd like to take a stab on this.

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-inlay-hints inlay/inline hints C-bug Category: bug E-easy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants