Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support per-folder settings in multi-root VSCode workspaces #17086

Open
jyn514 opened this issue Apr 16, 2024 · 3 comments
Open

support per-folder settings in multi-root VSCode workspaces #17086

jyn514 opened this issue Apr 16, 2024 · 3 comments
Labels
A-config configuration A-lsp LSP conformance issues and missing features C-feature Category: feature request

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 16, 2024

VSCode has a feature where multiple "folders" can be part of the same "workspace" (shown in the same window, basically). for the most part, this works out of the box with rust-analyzer. however, RA doesn't allow settings to be configured per-folder, only per-workspace.

image

the toml extension i'm using allows per-folder settings, so presumably this is under the control of the extension. it would be nice if it were supported by RA.

image

@jyn514 jyn514 added the C-feature Category: feature request label Apr 16, 2024
@Veykril
Copy link
Member

Veykril commented Apr 16, 2024

Would be great to have, but I don't think the LSP allows us to do this ... And we'd also need to add support for multi configs for a server here (although we are technically implementing this already for the rust-analyzer.toml). Or we spawn a server per folder in a vscode workspace which will blow up resource usage, so not really a nice option either.

@Veykril Veykril added A-lsp LSP conformance issues and missing features A-config configuration labels Apr 16, 2024
@jyn514
Copy link
Member Author

jyn514 commented Apr 16, 2024

hmm, the c++ extension manages it somehow, presumably it's going through the lsp protocol? i don't know exactly how it does it.
image

@jyn514
Copy link
Member Author

jyn514 commented Apr 19, 2024

for the most part, this works out of the box with rust-analyzer.

i take it back; rust-analyzer isn't showing red squigglies for projects in the workspace :( go-to-definition and such work ok, but there's no error indicator for methods or paths that don't exist. never mind, i just had check-on-save turned off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config configuration A-lsp LSP conformance issues and missing features C-feature Category: feature request
Projects
None yet
Development

No branches or pull requests

2 participants